Add azd ai dataset extension for Foundry datasets - #9499

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:269

• azd-code-reviewer: The promised “unknown name lists nothing” behavior is not implemented for the service's 404 response. ListDatasetVersions returns that 404 as an error (the API tests model this case), so this branch exits before renderDatasets can emit the empty array/message. Convert only IsNotFound(err) to an empty DatasetList and continue; keep propagating other failures.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/operations.go:591

• azd-code-reviewer: A malformed 200 response is currently converted into an empty container. readBlobPage then succeeds, and the caller reports that the dataset “holds no downloadable file,” hiding the actual storage/protocol failure. Return the XML decoding error from parseBlobPage and propagate it through readBlobPage instead of treating invalid XML as an empty listing.
  cli/azd/extensions/azure.ai.dataset/tests/cli/dataset_test.go:51
• azd-code-reviewer: Cleanup failures are silently ignored here and delete failures below are unchecked, so a green live suite can leave dataset versions in the shared Foundry project. Make the list decode and every delete required successes so cleanup failures are reported instead of leaking test state.
  cli/azd/extensions/azure.ai.dataset/README.md:22
• This command as documented always fails because delete requires --version. Include the required flag so the command table contains a runnable invocation.

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/internal/messages/messages.go:502

• Use Go 1.26's errors.AsType here; this repository's modernization checks reject the older target-variable errors.As pattern.
  cli/azd/extensions/azure.ai.dataset/internal/cmd/output.go:29
• azd-code-reviewer: Unknown output formats are silently treated as human output because the inherited flag is never constrained. For example, -o yaml exits successfully and prints a table, and -o none still prints output. Register per-command azdext.FlagOptions with the formats each command actually supports so invalid values fail before RunE.

	return strings.ToLower(v)

cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/pages.go:61

• azd-code-reviewer: Hitting a repeated link or the page cap returns a partial listing as a successful result. Callers such as LatestVersion and UploadNextVersion then treat that prefix as complete and can choose an already-used version; the direct os.Stderr warning also bypasses the command's injected writer. Return a truncation error (or explicit incomplete result) and let the command render it through its writer instead of continuing with partial data.
  cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/models.go:207
• azd-code-reviewer: Uploading loads the complete dataset into memory, converts it to a string, and later converts it back to []byte, so a large Foundry dataset requires several full-size allocations before the HTTP client can send anything. Stream validation and upload from the file (while handling the BOM on the reader) to keep memory bounded by row/buffer size.
  cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/models.go:51
• These duplicate fields leak the service's inconsistent spelling into the public -o json contract: a response containing data_uri is re-emitted as data_uri, while current responses emit dataUri. Scripts therefore need two schemas even though ResolvedBlobURI already normalizes them internally. Normalize during unmarshalling or map to a stable output DTO before encoding.

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:269

• azd-code-reviewer: A 404 still exits non-zero here, despite this command's documented contract that an unknown name returns an empty successful list. The client and its tests explicitly treat a first-page 404 as the service's “dataset does not exist” response, so normalize that status to an empty DatasetList before rendering.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:335

• azd-code-reviewer: An unknown dataset can be returned as a 404 by this API, but that path bypasses the concise DatasetNotFound handling below and exposes the wrapped service response instead. Translate IsNotFound(err) here so show has the same brief not-found behavior for both empty-list and 404 service variants.

				list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
				if err != nil {
					return messages.ResolvingLatestDatasetVersion(name, err)
				}

cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/operations.go:591

• azd-code-reviewer: XML decoding failures are discarded, so malformed or truncated Storage responses become an empty successful listing and are later reported as “dataset holds no downloadable file.” Return the unmarshal error through readBlobPage so transport/protocol failures are not misclassified as valid empty datasets.
  cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/models.go:51
• azd-code-reviewer: The service spellings are modeled as separate exported JSON fields, so -o json emits dataUri for one backend response and data_uri for another (and likewise for blob/content URIs). That makes the scripting schema depend on the service payload; the CLI test already expects the stable dataUri name. Normalize these aliases during unmarshalling or render a dedicated output DTO with one canonical field set.
  cli/azd/extensions/azure.ai.dataset/internal/cmd/output.go:29
• azd-code-reviewer: Unsupported --output values silently fall through to human output because none of the leaf commands registers SDK FlagOptions. Established extensions register AllowedValues: []string{"json", "table"} and a default (for example azure.ai.connections/internal/cmd/connection.go:97-99), which also keeps help and metadata accurate. Register those options on every runnable command instead of treating any non-JSON string as table output.

	v, err := cmd.Flags().GetString("output")
	if err != nil {
		return ""
	}
	return strings.ToLower(v)

cli/azd/extensions/azure.ai.dataset/README.md:22

• This documented invocation always fails because delete requires --version. Include the required flag so users can run the example as written.

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/resolver.go:369

• The resolver newly reads both endpoint variables, but the environment-variable reference documents only FOUNDRY_PROJECT_ENDPOINT and describes it as agents-only; AZURE_AI_PROJECT_ENDPOINT is absent. Update cli/azd/docs/environment-variables.md in this PR so the repository's environment-variable source of truth matches this extension's fallback behavior.

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:269

• azd-code-reviewer: A missing dataset is represented as a 404 by this API (the client already handles that case in latestRegisteredVersion), so this branch still makes versions list <unknown> fail even though the command and its new live test promise an empty successful list. Treat only non-404 errors as failures; the renderer already normalizes a nil list to [].

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/messages/messages.go:503

• The repository's Go 1.26 guidance requires errors.AsType rather than the legacy target-pointer errors.As pattern. Using AsType here also removes the mutable target variables and keeps this code compatible with the enforced go fix modernization.
  cli/azd/extensions/azure.ai.dataset/internal/cmd/asset_name_parity_test.go:20
• azd-code-reviewer: Enforcing the create-time character set on every named verb makes existing datasets unmanageable if they were created by another client or an older API with a name outside this regex. The linked evaluations work explicitly calls out datasets containing spaces, and the API client already safely path-escapes such names. Restrict this validation to operations that create a new name; lookups, updates, version listings, and deletes should accept existing service-returned names.

// Every verb that takes a <name> refuses an invalid one locally.
//
// The sibling extension carries a second copy of these commands, and the guard
// reached its dataset verbs but not its evaluator ones. Walking the tree rather
// than listing the verbs is the point: a verb added later is covered without
// anyone remembering to add it here.

cli/azd/extensions/azure.ai.dataset/README.md:8

• This setup command cannot currently succeed because this PR deliberately omits the registry.json entry; the TODO below confirms the extension is only reachable through a local source. Replace this with working local pack/publish/install instructions until the registry entry lands, otherwise the README's first onboarding step ends in an unresolved extension.

```console
$ azd extension install azure.ai.dataset
$ azd ai dataset --help

**cli/azd/extensions/azure.ai.dataset/README.md:22**
* `delete` requires `--version` and immediately errors without it, so this command table documents an invocation that cannot succeed. Include the required flag in the usage.

| azd ai dataset delete <name> | Delete a dataset version |

**cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/resolver.go:369**
* These new environment-variable reads are not fully reflected in the repository's required environment-variable reference: `FOUNDRY_PROJECT_ENDPOINT` currently says it is used only by `azure.ai.agents`, and `AZURE_AI_PROJECT_ENDPOINT` has no entry. Update `cli/azd/docs/environment-variables.md` so both fallback keys and this extension's precedence are documented.
**cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/pages.go:61**
* azd-code-reviewer: Writing this warning directly to process-global stderr bypasses Cobra's injected writer, so callers embedding the command cannot capture it and host-mediated invocations may lose it. Propagate truncation to the command layer and emit through `cmd.ErrOrStderr()` (or inject a warning writer into the client) instead of using `os.Stderr`.
**cli/azd/extensions/azure.ai.dataset/tests/cli/dataset_test.go:45**
* azd-code-reviewer: Cleanup performs a single version-list call even though this PR documents and tests that the listing can remain empty immediately after a publish. Create-only live tests can therefore finish before their version is visible, skip the delete loop, and leave datasets in the shared Foundry project. Track the published version from the create response or poll the listing with a bounded retry before declaring cleanup complete.
</details>

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:402

• The added CLI contract says delete is idempotent, but a backend that represents an absent version as 404 is converted into a nonzero exit here. Treat IsNotFound as a successful no-op and only return other delete failures.

			if err := ec.datasetClient.DeleteDatasetVersion(
				ctx, name, version, ProjectEndpointAPIVersion,
			); err != nil {
				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)
				}
				return messages.DeletingDatasetVersion(name, version, err)

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:269

• ListDatasetVersions can signal an unknown dataset with a 404 (the presence path already treats that response as absence), but this branch turns every error into a failed command. That contradicts the new empty-success test and means versions list <unknown> still exits nonzero on that service response. Render an empty list for IsNotFound and preserve other errors.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/README.md:22

• This documented invocation always fails because the command requires --version. Include the required flag so readers can successfully delete a version.

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/tests/cli/dataset_test.go:51

• Cleanup silently ignores listing, JSON-decoding, and delete failures, so the live suite can pass while leaving dataset versions in the shared Foundry project. Make cleanup failures visible and require each deletion to succeed.
  cli/azd/extensions/azure.ai.dataset/README.md:6
• The onboarding starts with an install command that cannot currently resolve: the same README states that no registry entry exists yet. Either add the registry entry before publishing this instruction or replace it with the local pack/publish flow so the first example is executable.

$ azd extension install azure.ai.dataset

cli/azd/extensions/azure.ai.dataset/internal/cmd/output.go:34

• Every non-JSON value falls through to human table output, and these commands never register azdext.FlagOptions for the inherited output flag. Consequently typos such as -o yaml succeed and emit a different format instead of being rejected. Register the supported values and default on each output-producing command, as the extension SDK expects.

	return strings.ToLower(v)
}

// isJSON reports whether the command should emit machine-readable output.
func isJSON(cmd *cobra.Command) bool {
	return outputFormat(cmd) == outputJSON

cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/operations.go:600

• A malformed or truncated 200 XML response is silently converted into an empty blob page. The caller then reports that the dataset has no downloadable file, hiding a service/proxy response failure as valid emptiness. Propagate the XML unmarshal error through ReadingListResponse instead.
  cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/resolver.go:330
• Validate explicitly reports a malformed project path through its second return value, but every resolution branch discards it. A Foundry host with /foo is therefore accepted and only fails later as an unrelated API 404. Either reject that path or propagate the intended warning to the command output.

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:406

• azd-code-reviewer: A 404 is turned into a failure here, which contradicts TestCLIDeleteIsIdempotent. The client tests establish that missing resources can surface as 404s, so idempotence currently depends on a particular backend returning 204 instead. Treat 404 as already deleted and only fail on other statuses.

				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:275

• azd-code-reviewer: versions list still propagates a first-page 404, even though the new CLI tests require an unknown dataset to succeed with an empty result. The client tests explicitly model an unknown dataset as a 404, so this path returns before renderDatasets can emit [] or the human-readable empty message. Convert only IsNotFound(err) into an empty DatasetList; keep propagating all other failures.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/store.go:17

• azd-code-reviewer: This reads only the legacy extensions.ai-agents.project.context key. The current azure.ai.projects implementation writes extensions.ai-projects.context and removes the legacy key, so following this extension's own azd ai project set <endpoint> suggestion still leaves dataset commands unable to resolve the endpoint. Read the current key first and retain the agents key only as a legacy fallback.
  cli/azd/extensions/azure.ai.dataset/README.md:7
• azd-code-reviewer: The PR deliberately omits the registry entry, and this README later acknowledges that azd extension install azure.ai.dataset cannot resolve yet. The opening quick start therefore fails in the repository state being merged. Replace it with working local pack/publish instructions until the registry entry lands, or defer this install snippet to that follow-up.

```console
$ azd extension install azure.ai.dataset
$ azd ai dataset --help

cli/azd/extensions/azure.ai.dataset/tests/cli/dataset_test.go:50

• azd-code-reviewer: Cleanup silently returns when listing fails or JSON is malformed, and delete failures are ignored. These live tests create persistent Foundry assets, so a transient auth/service error can leave datasets behind while the suite still passes. Make cleanup failures visible and retry the eventually consistent empty-list case before concluding there is nothing to remove.

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:275

• A 404 still takes the error path here, so versions list <unknown> exits non-zero instead of producing the empty result promised by the new tests and the comment below. Normalize only IsNotFound(err) to an empty DatasetList; keep other failures fatal. [azd-code-reviewer]

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:408

• The command's stated idempotence is not enforced: if the service returns 404 for an already-absent version, this branch returns an error even though TestCLIDeleteIsIdempotent requires success. Ignore IsNotFound and only surface other delete failures. [azd-code-reviewer]

				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)
				}
				return messages.DeletingDatasetVersion(name, version, err)

cli/azd/extensions/azure.ai.dataset/internal/messages/messages.go:510

• Go 1.26 modernization in this repository requires errors.AsType; the reusable lint workflow runs go fix -diff and rejects outstanding suggestions. Replace both pointer-target errors.As calls so this new workflow can pass.
  cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/resolver.go:369
• These new environment-variable reads are not reflected in the single-source reference: environment-variables.md still describes FOUNDRY_PROJECT_ENDPOINT as agents-only and has no AZURE_AI_PROJECT_ENDPOINT entry. Update that reference to include this extension and document the fallback/default behavior.
  cli/azd/extensions/azure.ai.dataset/README.md:6
• This opening installation command cannot currently work because the registry entry is deliberately absent, as lines 67–70 acknowledge. Replace it with the local azd x pack/publish flow until the registry follow-up lands, rather than giving readers a command guaranteed to fail. [azd-code-reviewer]

$ azd extension install azure.ai.dataset

cli/azd/extensions/azure.ai.dataset/internal/cmd/output.go:29

• Unsupported output values silently fall through to the human format, so a typo such as -o jsno exits successfully with non-JSON output. Register json and table as allowed values on every leaf command via azdext.RegisterFlagOptions, as established in azure.ai.routines/internal/cmd/routine_list.go:31 and azure.ai.skills/internal/cmd/skill_list.go:51. [azd-code-reviewer]

	v, err := cmd.Flags().GetString("output")
	if err != nil {
		return ""
	}
	return strings.ToLower(v)

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:341

• azd-code-reviewer: An unknown name can make the version-list request return 404, so show exits here with the full service response instead of the brief DatasetNotFound error promised by TestCLIUnknownDatasetIsBrief. Classify a first-page 404 as the missing dataset before wrapping other listing failures.

				list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
				if err != nil {
					return messages.ResolvingLatestDatasetVersion(name, err)
				}

cli/azd/extensions/azure.ai.dataset/README.md:22

• azd-code-reviewer: The documented delete invocation omits the required --version flag, so copying it always fails with “--version is required.” Include the required version argument in the command table.

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:275

• azd-code-reviewer: This still returns an error when the service answers 404 for an unknown dataset, contradicting the new CLI contract and TestCLIVersionsListOfAnUnknownNameSucceeds. Convert that specific response to an empty list so human output and -o json reach the intended renderer.

This issue also appears on line 338 of the same file.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/cmd/output.go:29

• azd-code-reviewer: No dataset command registers SDK FlagOptions for the inherited output flag, so any typo is accepted and every non-JSON value silently becomes human output (-o jsno exits 0 with a table). Register json and table as allowed values with the intended default on each output-producing command so scripts fail fast and help/metadata advertise the real formats.

	v, err := cmd.Flags().GetString("output")
	if err != nil {
		return ""
	}
	return strings.ToLower(v)

cli/azd/extensions/azure.ai.dataset/README.md:8

• azd-code-reviewer: This is currently a guaranteed failing onboarding command because this PR deliberately omits the registry entry, as the TODO below acknowledges. Until the follow-up lands, replace it with the local pack/publish installation flow or clearly mark the registry install command as unavailable; otherwise the first instruction in the README leaves every new user stuck.

This issue also appears on line 22 of the same file.

```console
$ azd extension install azure.ai.dataset
$ azd ai dataset --help

**cli/azd/extensions/azure.ai.dataset/internal/messages/messages.go:512**
* azd-code-reviewer: This new code uses the legacy `errors.As` target pattern even though the module is on Go 1.26 and the repository’s lint workflow rejects `go fix -diff` suggestions. Use `errors.AsType` (and run `go fix ./...`) so the new lint workflow does not fail.
**cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/models.go:51**
* azd-code-reviewer: `Dataset` is used as both the service wire model and the public `-o json` model. Because these duplicate fields retain their original tags, a response using `data_uri` is re-emitted as `data_uri`, while another backend spelling becomes `dataUri`; scripts cannot rely on one schema even though `ResolvedBlobURI` normalizes human output. Emit a dedicated output DTO or implement normalized JSON marshaling with one canonical URI field.
**cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/models.go:207**
* azd-code-reviewer: `--from-file` has no size bound, but this reads the entire dataset into memory, converts it to a string during validation, and later copies it back to `[]byte` for upload. Large but valid datasets can therefore consume several times their file size and terminate the extension. Validate rows from a stream and upload from the file (or enforce a documented size limit) instead of materializing the complete dataset repeatedly.
</details>

Previously missed (7) — in code that hasn't changed since the last review.

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:275

• azd-code-reviewer: A 404 from the versions endpoint still exits with an error, even though this command's stated contract and live test require an unknown name to return an empty successful list. Convert only IsNotFound into an empty DatasetList; continue propagating all other failures.

This issue also appears on line 338 of the same file.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:409

• azd-code-reviewer: Returning an error for a missing version contradicts the idempotent-delete contract pinned by TestCLIDeleteIsIdempotent. Treat a 404 as successful no-op deletion while preserving other service failures.

				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)

cli/azd/extensions/azure.ai.dataset/README.md:6

• azd-code-reviewer: This installation command cannot currently resolve because the same README states that registry.json deliberately has no azure.ai.dataset entry. Replace it with a working local pack/publish workflow until the registry entry lands, or add this snippet only with that follow-up.

This issue also appears on line 22 of the same file.

$ azd extension install azure.ai.dataset

cli/azd/extensions/azure.ai.dataset/CHANGELOG.md:18

• azd-code-reviewer: No command calls DownloadDatasetContent; show renders metadata only. This first-release changelog therefore advertises content readback that users cannot invoke. Remove this bullet or expose the behavior through a documented command.

- Reads dataset content back, whether the service hands out a blob URI or the
  container holding it.

cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/models.go:51

• azd-code-reviewer: These wire aliases leak into the public -o json schema because commands encode Dataset directly. A snake_case service response emits data_uri, while a camelCase response emits dataUri, so scripts get different field names for the same command. Map API models to a stable output DTO using ResolvedBlobURI() before rendering lists and details.
  cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/models.go:207
• azd-code-reviewer: Upload currently buffers the entire dataset several times: ReadFile allocates the file, validation converts rows to strings, the function returns another string, and UploadVersion converts it back to []byte. Large Foundry datasets can therefore exhaust memory before the upload starts. Validate from a stream, rewind/reopen the file, and pass an io.Reader to the blob request instead of materializing the full payload.
  cli/azd/extensions/azure.ai.dataset/internal/messages/messages.go:457
• azd-code-reviewer: This branch explicitly covers transient token-helper failures where the login may still be valid, but it records all of them as login_expired. That misclassifies extension error telemetry and can overstate expired-login failures. Use the generic auth-failure code unless the error provides specific evidence that the login expired.

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:340

• azd-code-reviewer: When the initial versions lookup returns 404, show exposes the service response instead of the brief DatasetNotFound error required by TestCLIUnknownDatasetIsBrief. Handle a not-found listing the same way as an empty listing.

				list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
				if err != nil {
					return messages.ResolvingLatestDatasetVersion(name, err)

cli/azd/extensions/azure.ai.dataset/README.md:22

• azd-code-reviewer: delete requires --version, so the documented command always fails with “--version is required.” Include the required flag in the command table.

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/internal/messages/messages.go:510

• azd-code-reviewer: This is the only remaining pre-Go-1.26 errors.As pattern in the extension. The repository requires errors.AsType, which avoids mutable target variables and is already used elsewhere in this module.

Previously missed (4) — in code that hasn't changed since the last review.

cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/pages.go:107

• azd-code-reviewer: Relative continuation links are resolved against the project endpoint rather than the URL that produced the page. For a real endpoint ending in /api/projects/<project>, a query-only link such as ?page=2 drops /datasets, and the tested /datasets?page=2 form drops the entire project path. Resolve each continuation against the current page URL and cover the test with a project-path endpoint.
  cli/azd/extensions/azure.ai.dataset/internal/cmd/root.go:63
• azd-code-reviewer: None of these executable commands registers the inherited --output contract with azdext.RegisterFlagOptions. As a result, unsupported values such as -o yaml silently fall through to table output, and generated metadata/completions do not advertise json or table. Register those allowed values with a table default on every leaf command, including versions list.

		newDatasetCreateCommand(),
		newDatasetUpdateCommand(),
		newDatasetListCommand(),
		newDatasetShowCommand(),
		newDatasetDeleteCommand(),

cli/azd/extensions/azure.ai.dataset/README.md:22

• The command table omits the required --version flag, so copying this documented command immediately fails with “--version is required.” Include the flag in the command syntax.

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/tests/cli/dataset_test.go:50

• azd-code-reviewer: Cleanup silently ignores both deletion failures here and listing/JSON failures above, so the live suite can pass while leaving paid project assets behind. Make cleanup report failures and account for the service's eventually consistent version listing before declaring cleanup complete.

cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/resolver.go:370

• These new reads are not reflected in the canonical environment-variable reference: FOUNDRY_PROJECT_ENDPOINT is still described as agents-only, and AZURE_AI_PROJECT_ENDPOINT has no entry. Update cli/azd/docs/environment-variables.md so both variables document this extension and the fallback behavior.
  cli/azd/extensions/azure.ai.dataset/internal/messages/messages.go:510
• This module targets Go 1.26, and the repository's go fix -diff CI check requires the modern errors.AsType form. Replace these target variables and errors.As calls so the new lint workflow does not report a modernization diff.

Previously missed (5) — in code that hasn't changed since the last review.

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:277

• azd-code-reviewer: An unknown dataset can return 404 from ListDatasetVersions (the API tests explicitly model that), so this branch exits before the documented empty-list rendering. TestCLIVersionsListOfAnUnknownNameSucceeds will therefore fail against that service behavior. Convert only a not-found response to an empty DatasetList and keep propagating other errors.

This issue also appears on line 414 of the same file.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/models.go:45

• azd-code-reviewer: These wire aliases leak into the public -o json schema because commands serialize Dataset directly. A camel-case response emits dataUri, while a snake-case response emits data_uri (and a response containing both emits both), so scripts do not get the stable shape promised by the CLI. Keep the service aliases in the transport model, but map command output to one normalized DTO using ResolvedBlobURI().
  cli/azd/extensions/azure.ai.dataset/README.md:22
• This documented command always fails because --version is required by newDatasetDeleteCommand. Include the required flag so the command table is executable as written.

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/validator.go:41

• azd-code-reviewer: The non-fatal path warning is discarded by every Resolve call site, so an account URL such as https://acct.services.ai.azure.com is accepted and later requests the wrong /datasets route instead of reporting the missing /api/projects/<project> path. Either reject this shape here or surface the warning through the command layer; returning a boolean that nobody reads leaves the endpoint validation incomplete.
  cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/pages.go:61
• azd-code-reviewer: This client-layer write bypasses Cobra's injected output/error writers. The warning cannot be captured by callers or tests and appears as process-global terminal output even during machine-readable commands. Return truncation information to the command layer (or inject a writer) and emit it through cmd.ErrOrStderr().

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:418

• azd-code-reviewer: This turns a 404 into an error, contradicting the new idempotent-delete contract and TestCLIDeleteIsIdempotent. Treat not-found as an already-deleted success while continuing to report every other service failure.

			if err := ec.datasetClient.DeleteDatasetVersion(
				ctx, name, version, ProjectEndpointAPIVersion,
			); err != nil {
				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)

Previously missed (2) — in code that hasn't changed since the last review.

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:173

• azd-code-reviewer: None of the dataset leaf commands register allowed values for the inherited --output flag. NewExtensionRootCommand only validates output through RegisterFlagOptions (cli/azd/pkg/azdext/extension_command.go:179-182), so values such as -o yaml or -o none silently produce human output. Register table and json on every leaf, as done in azure.ai.connections/internal/cmd/connection.go:97-99, and test invalid-format rejection.

	cmd.Flags().StringVar(&version, "version", "",
		"Version to publish. Omit to publish the next version after the latest registered.")
	cmd.Flags().StringVar(&endpointFlg, "project-endpoint", "", "Foundry project endpoint.")
	return cmd

cli/azd/extensions/azure.ai.dataset/README.md:22

• azd-code-reviewer: This documented invocation always fails because delete requires --version (internal/cmd/dataset.go:399-400). Include the required flag so the command table provides usable syntax.

| `azd ai dataset delete <name>` | Delete a dataset version |

Previously missed (5) — in code that hasn't changed since the last review.

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:277

• azd-code-reviewer: An unknown dataset can return 404 from ListDatasetVersions (as TestAFirstPage404IsStillAbsence establishes), so this returns an error before reaching the empty-list behavior promised below and exercised by the CLI test. Translate a first-page not-found into an empty DatasetList; continue surfacing every other error.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:340

• azd-code-reviewer: This resolves “latest” from one versions-list request, but the client documents that this listing is eventually consistent after publishing. Immediately after create it can therefore report the dataset missing, and after update it can show the previous version. Use a consistent latest-version lookup or bounded verification/retry before selecting the result.

				list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)

cli/azd/extensions/azure.ai.dataset/README.md:6

• azd-code-reviewer: This onboarding command cannot work with this PR: the registry entry is intentionally omitted, and this README itself says the extension cannot be resolved until that entry exists. Replace it with a verified local-source installation flow for now, or defer this example until the registry follow-up lands.

$ azd extension install azure.ai.dataset

cli/azd/extensions/azure.ai.dataset/README.md:22

• azd-code-reviewer: The documented delete invocation always fails because the implementation requires --version. Include the required flag so readers can run the command as shown.

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/operations.go:262

• azd-code-reviewer: Uploading loads the entire dataset into memory, converts it to a string, and then allocates another full []byte copy here before the PUT. With no documented size limit, a large dataset can consume several times its file size and terminate the CLI. Validate and upload from a stream, or enforce and document a bounded maximum size.

cli/azd/docs/environment-variables.md:172

• azd-code-reviewer: For this extension, AZD_EXT_DEBUG is parsed by isDebug to enable SDK/standard-library logging; the custom-command entry point never calls WaitForDebugger. This description therefore promises a debugger prompt that does not occur and should describe debug logging instead.

| `AZD_EXT_DEBUG` | If true, waits for a debugger to attach before the command runs. |

cli/azd/extensions/azure.ai.dataset/internal/messages/messages.go:535

• azd-code-reviewer: The repository's Go 1.26 guidance requires errors.AsType instead of the legacy target-pointer form of errors.As; the pre-commit go fix check can rewrite this. Use typed checks for both credential error types.

Previously missed (8) — in code that hasn't changed since the last review.

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:277

• azd-code-reviewer: The comment and CLI test define an unknown name as an empty successful listing, but a backend that returns 404 takes this unconditional error path. Normalize IsNotFound(err) to an empty DatasetList; otherwise versions list <unknown> still exits 1 on that valid service response.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:426

• azd-code-reviewer: TestCLIDeleteIsIdempotent says deleting an unregistered version succeeds, but a service/backend that expresses absence as 404 returns an error here. Treat not-found as successful deletion so idempotence does not depend on whether a deployment returns 204 or 404 for the same state.

			if err := ec.datasetClient.DeleteDatasetVersion(
				ctx, name, version, ProjectEndpointAPIVersion,
			); err != nil {
				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)

cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/list.go:80

• azd-code-reviewer: This fallback orders only the final digit run, so accepted versions such as 1.10.0 and 1.9.9 compare as 0 and 9. show without --version can therefore return the older version, and the next automatic upload can advance from the wrong baseline. Either compare numeric components or reject explicit versions outside the supported decimal/trailing-counter grammar.
  cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/operations.go:510
• azd-code-reviewer: A repeated marker proves the blob listing is incomplete, but this treats it as a normal final page and returns partial names. DownloadDatasetContent can then choose the wrong fallback file or report that no file exists. Return a truncation error on a repeated marker, as followPages already does for repeated nextLink values.
  cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/operations.go:402
• azd-code-reviewer: Every direct-download error triggers the container fallback, although only the expected 409 indicates that a file-looking URI is actually a container. A 403, timeout, or cancellation is instead masked by a second listing request and an unrelated final error. Preserve the storage status and fall back only for the container response; return other failures directly.
  cli/azd/extensions/azure.ai.dataset/README.md:22
• The documented delete invocation always fails because --version is required by the command. Include the required flag in the command table so users can run the example successfully.

| `azd ai dataset delete <name>` | Delete a dataset version |

cli/azd/extensions/azure.ai.dataset/README.md:6

• This quick-start command cannot resolve because this PR deliberately omits the registry entry, as the TODO at lines 67–70 notes. Mark it as a post-release command or replace it with complete local pack/publish/install steps so the README's first workflow is currently usable.

$ azd extension install azure.ai.dataset

cli/azd/extensions/azure.ai.dataset/CHANGELOG.md:3

• This extension is still unpublished—the README says the registry entry remains TODO—so an official release dated 2026-08-20 has not occurred. Keep the entry marked Unreleased until the release pipeline publishes it; otherwise the release history records a date before the artifact was available.

## 1.0.0-beta.17 (2026-08-20)

Previously missed (4) — in code that hasn't changed since the last review.

cli/azd/extensions/azure.ai.dataset/internal/foundry/projectctx/store.go:17

• azd-code-reviewer: This reads only the legacy agents key, but azd ai project set writes extensions.ai-projects.context and removes the legacy key during migration (azure.ai.projects/internal/cmd/project_context_store.go:14-20,84-117). As a result, the resolver's own suggested azd ai project set remediation still leaves this extension without an endpoint. Read the projects key first and retain this key only as a legacy fallback; update the documented cascade too.
  cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:277
• azd-code-reviewer: The comment below promises that an unknown name produces an empty successful list, but a backend 404 is returned here before rendering. The client tests explicitly model 404 as the service's unknown-dataset response, so normalize that status to an empty list and preserve errors for other statuses.

			list, err := ec.datasetClient.ListDatasetVersions(ctx, name, ProjectEndpointAPIVersion)
			if err != nil {
				return messages.ListingDatasetVersions(name, err)
			}

cli/azd/extensions/azure.ai.dataset/internal/pkg/dataset_api/models.go:207

• azd-code-reviewer: ReadFile loads the entire dataset, the return conversion retains another full string copy, and UploadVersion converts it back to []byte before sending. With no documented size cap, ordinary large datasets can consume several times their size in memory and terminate the CLI. Validate the JSONL as a stream, then reopen the file and stream it into the upload request.
  cli/azd/extensions/azure.ai.dataset/CHANGELOG.md:18
• azd-code-reviewer: This release note promises that users can read dataset content back, but DownloadDatasetContent has no production caller and dataset show only emits metadata/URI fields. Remove this claim or expose a command/flag that actually writes the content.

- Reads dataset content back, whether the service hands out a blob URI or the
  container holding it.

cli/azd/extensions/azure.ai.dataset/internal/cmd/dataset.go:425

• azd-code-reviewer: The live test documents delete as idempotent, but a service 404 is converted into a command failure here. Treat not-found as already deleted and continue to the normal success response; only propagate other delete failures.

			if err := ec.datasetClient.DeleteDatasetVersion(
				ctx, name, version, ProjectEndpointAPIVersion,
			); err != nil {
				if dataset_api.IsNotFound(err) {
					return messages.DatasetVersionNotFound(name, version)
				}
				return messages.DeletingDatasetVersion(name, version, err)